Add new -J flag for enhanced DICOM metadata extraction#959
Closed
hanayik wants to merge 4 commits intodevelopmentfrom
Closed
Add new -J flag for enhanced DICOM metadata extraction#959hanayik wants to merge 4 commits intodevelopmentfrom
hanayik wants to merge 4 commits intodevelopmentfrom
Conversation
Collaborator
|
@hanayik this is an interesting PR. It has an elegantly minimal implementation and can extract a lot of code. However, I do not think it should be included in the main distribution, or if it is it should only be bundled with a compiler directive. A few comments:
I do think this is a situation where using pydicom with its robust DICOM handling and actively maintained DICOM dictionaries might be the optimal solution. I like the idea of saving these as a JSON file, but maybe not the same JSON used as a BIDS sidecar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new -J flag for enhanced DICOM metadata extraction
Summary
This PR introduces a new
-Jcommand-line option to dcm2niix that enables more DICOM metadata extraction to JSON format, going beyond the standard BIDS sidecar fields.