Skip to content

Fix integral action for AntiWindupStrategy::NONE (backport #432)#433

Merged
christophfroehlich merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-432
Jul 22, 2025
Merged

Fix integral action for AntiWindupStrategy::NONE (backport #432)#433
christophfroehlich merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-432

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Jul 21, 2025

There was no integral action with AntiWindupStrategy::NONE. Instead, it just should not saturate.

I fixed two other warning messages btw.


This is an automatic backport of pull request #432 done by Mergify.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.63%. Comparing base (6d0482f) to head (2ea7d61).

Files with missing lines Patch % Lines
control_toolbox/include/control_toolbox/pid.hpp 0.00% 1 Missing ⚠️
control_toolbox/src/pid.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy     #433      +/-   ##
==========================================
- Coverage   76.76%   76.63%   -0.14%     
==========================================
  Files          29       29              
  Lines        1945     1947       +2     
  Branches      114      114              
==========================================
- Hits         1493     1492       -1     
- Misses        379      383       +4     
+ Partials       73       72       -1     
Flag Coverage Δ
unittests 76.63% <50.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
control_toolbox/include/control_toolbox/pid.hpp 65.09% <0.00%> (-1.89%) ⬇️
control_toolbox/src/pid.cpp 71.50% <66.66%> (-0.24%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 44eaf81 into jazzy Jul 22, 2025
12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-432 branch July 22, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants