Fix calculation of tracking time constant (backport #511)#525
Merged
christophfroehlich merged 1 commit intokiltedfrom Oct 16, 2025
Merged
Fix calculation of tracking time constant (backport #511)#525christophfroehlich merged 1 commit intokiltedfrom
christophfroehlich merged 1 commit intokiltedfrom
Conversation
(cherry picked from commit 618c961)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kilted #525 +/- ##
=========================================
Coverage ? 82.61%
=========================================
Files ? 29
Lines ? 1985
Branches ? 113
=========================================
Hits ? 1640
Misses ? 276
Partials ? 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a couple of issues with tracking time constant used for back propagation anti-windup strategy
Note: maybe there is a better way of fixing this but this resolved my issue where I was unable to change gains using rqt when i-gain was set to zero and tracking time constant was at its default of zero.
This is an automatic backport of pull request #511 done by Mergify.