Replace deprecated rclcpp::spin_some() (backport #541)

[mergify]

Overview

This PR replaces deprecated rclcpp::spin_some(...) calls in control_toolbox/test/pid_ros_parameters_tests.cpp with a rclcpp::executors::SingleThreadedExecutor, as suggested in #488.

What changed

Files changed are:

• control_toolbox/control_toolbox/test/pid_ros_parameters_tests.cpp

In this PR we update control_toolbox/control_toolbox/test/pid_ros_parameters_tests.cpp so that the two tests which were using the deprecated rclcpp::spin_some(...) now create a rclcpp::executors::SingleThreadedExecutor, add the test node to it once, and call executor.spin_some() instead. This applies to TEST(PidParametersTest, SetParametersTest) and to TEST(PidParametersTest, SetBadParametersTest), where we replaced all the previous rclcpp::spin_some(...) calls with the executor-based version to match the current ROS 2 recommendation and to remove the deprecation warning.

Notes for Reviewer

I am very open to feedback and am happy to make any changes that are requested.

---

This is an automatic backport of pull request #541 done by Mergify.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.74%. Comparing base (2573852) to head (3b38374).

Additional details and impacted files

@@            Coverage Diff             @@
##           kilted     #542      +/-   ##
==========================================
+ Coverage   82.61%   82.74%   +0.12%     
==========================================
  Files          29       29              
  Lines        1985     1999      +14     
  Branches      113      113              
==========================================
+ Hits         1640     1654      +14     
  Misses        276      276              
  Partials       69       69              

Flag	Coverage Δ
unittests	82.74% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
control_toolbox/test/pid_ros_parameters_tests.cpp	99.03% <100.00%> (+0.01%)	⬆️
control_toolbox/test/pid_ros_publisher_tests.cpp	94.76% <100.00%> (+0.32%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.