Skip to content

use gz-physics#283 to implement joint_states/effort feedback (backport #186)#431

Closed
mergify[bot] wants to merge 1 commit intohumblefrom
mergify/bp/humble/pr-186
Closed

use gz-physics#283 to implement joint_states/effort feedback (backport #186)#431
mergify[bot] wants to merge 1 commit intohumblefrom
mergify/bp/humble/pr-186

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 28, 2024

Fixes joint_states/effort being zero for joints with <state_interface name="effort" /> in combination with joint_state_broadcaster/JointStateBroadcaster by using the JointTransmittedWrench component introduced by gazebosim/gz-physics#283.

The joint axis is hard coded to z. I did not yet look into reading out the actual <axis> of the joint and extracting the respective force/torque component of the wrench.


This is an automatic backport of pull request #186 done by Mergify.

(cherry picked from commit cc66e73)

# Conflicts:
#	ign_ros2_control/src/ign_system.cpp
@mergify mergify bot requested a review from ahcorde as a code owner October 28, 2024 09:02
@mergify mergify bot added the conflicts label Oct 28, 2024
@mergify
Copy link
Contributor Author

mergify bot commented Oct 28, 2024

Cherry-pick of cc66e73 has failed:

On branch mergify/bp/humble/pr-186
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit cc66e73.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ign_ros2_control/src/ign_system.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ahcorde ahcorde closed this Oct 28, 2024
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-186 branch January 3, 2025 19:36
@federicociresola
Copy link

why did you close this PR without merge?

@christophfroehlich
Copy link
Member

exactly: #186 (comment)

@christophfroehlich christophfroehlich restored the mergify/bp/humble/pr-186 branch June 10, 2025 20:45
@christophfroehlich
Copy link
Member

See #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants