Skip to content

Fix ackermann demo (backport #582)#583

Merged
ahcorde merged 4 commits intokiltedfrom
mergify/bp/kilted/pr-582
May 26, 2025
Merged

Fix ackermann demo (backport #582)#583
ahcorde merged 4 commits intokiltedfrom
mergify/bp/kilted/pr-582

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented May 21, 2025

From issue #438

  1. According to the ros2_controllers documentation, the order of joints in ackermann_drive_controller.yaml is reversed.
  2. The left front wheel and right front wheel are reversed in test_ackermann_drive.xacro.urdf.
  3. The rotation direction of the front wheels is corrected.

I tested these changes on humble branch and the Ackermann vehicle worked well.


Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

This is an automatic backport of pull request #582 done by [Mergify](https://mergify.com).

(cherry picked from commit 51c1d10)

# Conflicts:
#	gz_ros2_control_demos/config/ackermann_drive_controller.yaml
@mergify mergify bot added the conflicts label May 21, 2025
@mergify mergify bot requested a review from ahcorde as a code owner May 21, 2025 08:09
@mergify
Copy link
Contributor Author

mergify bot commented May 21, 2025

Cherry-pick of 51c1d10 has failed:

On branch mergify/bp/kilted/pr-582
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit 51c1d10.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   gz_ros2_control_demos/urdf/test_ackermann_drive.xacro.urdf

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   gz_ros2_control_demos/config/ackermann_drive_controller.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request May 21, 2025
6 tasks
@ahcorde ahcorde added the kilted label May 21, 2025
@ahcorde ahcorde merged commit 7d3218d into kilted May 26, 2025
5 checks passed
@ahcorde ahcorde deleted the mergify/bp/kilted/pr-582 branch May 26, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants