Merged
Conversation
Member
Author
|
@Mergifyio backport kilted jazzy |
Contributor
✅ Backports have been createdDetails
|
ahcorde
requested changes
Jun 6, 2025
Collaborator
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
For kilted and rolling we can use 3.20, but for jazzy I think 3.10 it's fine
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.5) | |||
| cmake_minimum_required(VERSION 3.10) | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| cmake_minimum_required(VERSION 3.10) | |
| cmake_minimum_required(VERSION 3.20) |
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.5) | |||
| cmake_minimum_required(VERSION 3.10) | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| cmake_minimum_required(VERSION 3.10) | |
| cmake_minimum_required(VERSION 3.20) |
Member
Author
|
My approach was to bump it to the lowest non-deprecated version unless we would need it, but everything is fine for me |
ahcorde
approved these changes
Jun 6, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
(cherry picked from commit 2cde962)
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
(cherry picked from commit 2cde962)
This was referenced Jun 6, 2025
ahcorde
pushed a commit
that referenced
this pull request
Jun 6, 2025
ahcorde
pushed a commit
that referenced
this pull request
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake < 3.10 is deprecated on some platforms ros-controls/ros2_control_cmake#8 (review)