Skip to content

Remove deprecated on_init #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

Remove deprecated on_init #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions gz_ros2_control/include/gz_ros2_control/gz_system.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,6 @@ class GazeboSimSystemPrivate;
class GazeboSimSystem : public GazeboSimSystemInterface
{
public:
// Documentation Inherited
[[deprecated(
"Replaced by GazeboSimSystem::on_init(const "
"hardware_interface::HardwareComponentInterfaceParams & params).")]]
CallbackReturn on_init(const hardware_interface::HardwareInfo & info) override;

// Documentation Inherited
CallbackReturn on_init(const hardware_interface::HardwareComponentInterfaceParams & params)
override;
Expand Down
23 changes: 0 additions & 23 deletions gz_ros2_control/src/gz_system.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,29 +575,6 @@ void GazeboSimSystem::registerSensors(
});
}

CallbackReturn
GazeboSimSystem::on_init(const hardware_interface::HardwareInfo & info)
{
#ifdef _MSC_VER
#pragma warning(push)
#pragma warning(disable : 4996)
#else
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
if (hardware_interface::SystemInterface::on_init(info) !=
CallbackReturn::SUCCESS)
{
return CallbackReturn::ERROR;
}
return CallbackReturn::SUCCESS;
#ifdef _MSC_VER
#pragma warning(pop)
#else
#pragma GCC diagnostic pop
#endif
}

CallbackReturn
GazeboSimSystem::on_init(const hardware_interface::HardwareComponentInterfaceParams & params)
{
Expand Down
Loading