Merge branch 'master' into add/overrun/parameters

saikishor · web-flow · commit 924f4505c1cc · 2025-09-18T18:20:51.000+02:00
diff --git a/.github/workflows/humble-source-build.yml b/.github/workflows/humble-source-build.yml
@@ -13,6 +13,11 @@ on:
       - '**/package.xml'
       - '**/CMakeLists.txt'
       - 'ros2_control.humble.repos'
+  pull_request:
+    branches:
+      - humble
+    paths:
+      - .github/workflows/humble-source-build.yml
   schedule:
     # Run every day to detect flakiness and broken dependencies
     - cron: '03 3 * * MON-FRI'
@@ -23,4 +28,4 @@ jobs:
     with:
       ros_distro: humble
       ref: humble
-      os_name: ubuntu-22.04
+      container: ubuntu:22.04
diff --git a/.github/workflows/jazzy-source-build.yml b/.github/workflows/jazzy-source-build.yml
@@ -13,6 +13,11 @@ on:
       - '**/package.xml'
       - '**/CMakeLists.txt'
       - 'ros2_control.jazzy.repos'
+  pull_request:
+    branches:
+      - jazzy
+    paths:
+      - .github/workflows/jazzy-source-build.yml
   schedule:
     # Run every day to detect flakiness and broken dependencies
     - cron: '03 3 * * MON-FRI'
diff --git a/.github/workflows/rolling-semi-binary-build-win.yml b/.github/workflows/rolling-semi-binary-build-win.yml
@@ -42,7 +42,5 @@ jobs:
     with:
       ros_distro: rolling
       pixi_dependencies: typeguard jinja2 boost compilers
-      windows_dependencies: ros2_control.windows.rolling.repos
       ninja_packages: rsl
-      skip_packages: diagnostic_remote_logging generate_parameter_library_example_external generate_parameter_library_example
       target_cmake_args: -DBUILD_TESTING=OFF
diff --git a/.github/workflows/rolling-source-build.yml b/.github/workflows/rolling-source-build.yml
@@ -14,6 +14,11 @@ on:
       - '**/CMakeLists.txt'
       - 'ros2_control.rolling.repos'
       - 'ros2_control.kilted.repos'
+  pull_request:
+    branches:
+      - master
+    paths:
+      - .github/workflows/rolling-source-build.yml
   schedule:
     # Run every day to detect flakiness and broken dependencies
     - cron: '03 3 * * MON-FRI'
diff --git a/hardware_interface/include/hardware_interface/types/statistics_types.hpp b/hardware_interface/include/hardware_interface/types/statistics_types.hpp
@@ -169,7 +169,7 @@ class MovingAverageStatistics
    *
    *  @param item The item that was observed
    */
-  virtual void add_measurement(const double item)
+  void add_measurement(const double item)
   {
     std::lock_guard<DEFAULT_MUTEX> guard{mutex_};
 
diff --git a/ros2_control.humble.repos b/ros2_control.humble.repos
@@ -1,9 +1,9 @@
 repositories:
-  ros-controls/realtime_tools:
+  realtime_tools:
     type: git
     url: https://github.com/ros-controls/realtime_tools.git
     version: humble
-  ros-controls/control_msgs:
+  control_msgs:
     type: git
     url: https://github.com/ros-controls/control_msgs.git
     version: humble
diff --git a/ros2_control.jazzy.repos b/ros2_control.jazzy.repos
@@ -1,13 +1,13 @@
 repositories:
-  ros-controls/realtime_tools:
+  realtime_tools:
     type: git
     url: https://github.com/ros-controls/realtime_tools.git
     version: jazzy
-  ros-controls/control_msgs:
+  control_msgs:
     type: git
     url: https://github.com/ros-controls/control_msgs.git
     version: jazzy
-  ros-controls/ros2_control_cmake:
+  ros2_control_cmake:
     type: git
     url: https://github.com/ros-controls/ros2_control_cmake.git
     version: master
diff --git a/ros2_control.kilted.repos b/ros2_control.kilted.repos
@@ -1,13 +1,13 @@
 repositories:
-  ros-controls/realtime_tools:
+  realtime_tools:
     type: git
     url: https://github.com/ros-controls/realtime_tools.git
     version: master
-  ros-controls/control_msgs:
+  control_msgs:
     type: git
     url: https://github.com/ros-controls/control_msgs.git
     version: master
-  ros-controls/ros2_control_cmake:
+  ros2_control_cmake:
     type: git
     url: https://github.com/ros-controls/ros2_control_cmake.git
     version: master
diff --git a/ros2_control.rolling.repos b/ros2_control.rolling.repos
@@ -1,13 +1,13 @@
 repositories:
-  ros-controls/realtime_tools:
+  realtime_tools:
     type: git
     url: https://github.com/ros-controls/realtime_tools.git
     version: master
-  ros-controls/control_msgs:
+  control_msgs:
     type: git
     url: https://github.com/ros-controls/control_msgs.git
     version: master
-  ros-controls/ros2_control_cmake:
+  ros2_control_cmake:
     type: git
     url: https://github.com/ros-controls/ros2_control_cmake.git
     version: master
diff --git a/ros2_control.windows.rolling.repos b/ros2_control.windows.rolling.repos
diff --git a/ros_controls.humble.repos b/ros_controls.humble.repos
@@ -1,21 +1,21 @@
 repositories:
-  ros-controls/gz_ros2_control:
+  gz_ros2_control:
     type: git
     url: https://github.com/ros-controls/gz_ros2_control.git
     version: humble
-  ros-controls/ros2_control_demos:
+  ros2_control_demos:
     type: git
     url: https://github.com/ros-controls/ros2_control_demos.git
     version: humble
-  ros-controls/ros2_controllers:
+  ros2_controllers:
     type: git
     url: https://github.com/ros-controls/ros2_controllers.git
     version: humble
-  ros-controls/control_toolbox:
+  control_toolbox:
     type: git
     url: https://github.com/ros-controls/control_toolbox.git
     version: humble
-  ros-controls/kinematics_interface:
+  kinematics_interface:
     type: git
     url: https://github.com/ros-controls/kinematics_interface.git
     version: humble
diff --git a/ros_controls.jazzy.repos b/ros_controls.jazzy.repos
@@ -1,25 +1,25 @@
 repositories:
-  ros-controls/gz_ros2_control:
+  gz_ros2_control:
     type: git
     url: https://github.com/ros-controls/gz_ros2_control.git
     version: jazzy
-  ros-controls/ros2_control_demos:
+  ros2_control_demos:
     type: git
     url: https://github.com/ros-controls/ros2_control_demos.git
     version: jazzy
-  ros-controls/ros2_controllers:
+  ros2_controllers:
     type: git
     url: https://github.com/ros-controls/ros2_controllers.git
     version: jazzy
-  ros-controls/control_toolbox:
+  control_toolbox:
     type: git
     url: https://github.com/ros-controls/control_toolbox.git
     version: jazzy
-  ros-controls/kinematics_interface:
+  kinematics_interface:
     type: git
     url: https://github.com/ros-controls/kinematics_interface.git
     version: jazzy
-  ros-controls/topic_based_hardware_interfaces:
+  topic_based_hardware_interfaces:
     type: git
     url: https://github.com/ros-controls/topic_based_hardware_interfaces.git
     version: main
diff --git a/ros_controls.kilted.repos b/ros_controls.kilted.repos
@@ -1,25 +1,25 @@
 repositories:
-  ros-controls/gz_ros2_control:
+  gz_ros2_control:
     type: git
     url: https://github.com/ros-controls/gz_ros2_control.git
     version: rolling
-  ros-controls/ros2_control_demos:
+  ros2_control_demos:
     type: git
     url: https://github.com/ros-controls/ros2_control_demos.git
     version: master
-  ros-controls/ros2_controllers:
+  ros2_controllers:
     type: git
     url: https://github.com/ros-controls/ros2_controllers.git
     version: master
-  ros-controls/control_toolbox:
+  control_toolbox:
     type: git
     url: https://github.com/ros-controls/control_toolbox.git
     version: ros2-master
-  ros-controls/kinematics_interface:
+  kinematics_interface:
     type: git
     url: https://github.com/ros-controls/kinematics_interface.git
     version: master
-  ros-controls/topic_based_hardware_interfaces:
+  topic_based_hardware_interfaces:
     type: git
     url: https://github.com/ros-controls/topic_based_hardware_interfaces.git
     version: main
diff --git a/ros_controls.rolling.repos b/ros_controls.rolling.repos
@@ -1,25 +1,25 @@
 repositories:
-  ros-controls/gz_ros2_control:
+  gz_ros2_control:
     type: git
     url: https://github.com/ros-controls/gz_ros2_control.git
     version: rolling
-  ros-controls/ros2_control_demos:
+  ros2_control_demos:
     type: git
     url: https://github.com/ros-controls/ros2_control_demos.git
     version: master
-  ros-controls/ros2_controllers:
+  ros2_controllers:
     type: git
     url: https://github.com/ros-controls/ros2_controllers.git
     version: master
-  ros-controls/control_toolbox:
+  control_toolbox:
     type: git
     url: https://github.com/ros-controls/control_toolbox.git
     version: ros2-master
-  ros-controls/kinematics_interface:
+  kinematics_interface:
     type: git
     url: https://github.com/ros-controls/kinematics_interface.git
     version: master
-  ros-controls/topic_based_hardware_interfaces:
+  topic_based_hardware_interfaces:
     type: git
     url: https://github.com/ros-controls/topic_based_hardware_interfaces.git
     version: main

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ class MovingAverageStatistics`
`169`	`169`	`*`
`170`	`170`	`* @param item The item that was observed`
`171`	`171`	`*/`
`172`		`- virtual void add_measurement(const double item)`
	`172`	`+ void add_measurement(const double item)`
`173`	`173`	`{`
`174`	`174`	`std::lock_guard<DEFAULT_MUTEX> guard{mutex_};`
`175`	`175`