Skip to content

Conversation

@saikishor
Copy link
Member

@saikishor saikishor commented Jul 3, 2025

@saikishor saikishor marked this pull request as ready for review July 4, 2025 07:20
@github-actions github-actions bot requested review from VX792, destogl and moriarty July 4, 2025 07:22
@saikishor saikishor added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Jul 5, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, I confirm that this fixes #2248

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (9371d59) to head (fa979c1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
joint_limits/src/joint_range_limiter.cpp 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
+ Coverage   88.88%   88.90%   +0.02%     
==========================================
  Files         148      148              
  Lines       16946    16950       +4     
  Branches     1443     1448       +5     
==========================================
+ Hits        15062    15070       +8     
+ Misses       1320     1318       -2     
+ Partials      564      562       -2     
Flag Coverage Δ
unittests 88.90% <95.83%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/resource_manager.cpp 77.89% <100.00%> (ø)
...nt_limits/include/joint_limits/data_structures.hpp 80.55% <100.00%> (+4.69%) ⬆️
joint_limits/src/joint_limits_helpers.cpp 89.69% <100.00%> (+1.45%) ⬆️
joint_limits/src/joint_soft_limiter.cpp 89.68% <100.00%> (+0.71%) ⬆️
joint_limits/test/test_joint_soft_limiter.cpp 99.64% <100.00%> (+<0.01%) ⬆️
joint_limits/src/joint_range_limiter.cpp 90.90% <80.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmagyar bmagyar merged commit 7061ac4 into ros-controls:master Jul 16, 2025
23 of 27 checks passed
@bmagyar bmagyar deleted the fix/crashing/joint_limiters branch July 16, 2025 17:56
mergify bot pushed a commit that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ros2_control_demo_example_7 throws bad optional access

3 participants