hardware_interface: fix get_node() docs in HardwareComponentInterface #2473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
christophfroehlich,
erickisos,
harderthan,
Maverobot,
rosterloh and
saikishor
|
you are again opening a PR with the same changes like in #2471, why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the fix from issue #2419 to the current codebase.
In older versions of
ros2_control,get_node()existed separately insystem_interface.hppandsensor_interface.hpp, and the Doxygen comments thereincorrectly referenced ActuatorInterface.
In the current version,
get_node()lives only in the base class(
hardware_component_interface.hpp). However, its comment still incorrectlyreferred to System_Interface.
This PR corrects the documentation to properly reference
HardwareComponentInterface.
Fixes #2419