Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 29, 2026

#2997 (comment)

InterfaceInfo is only passed inside a std::vector (its size does not change when the object changes). But the memory layout of the struct changes and accessing it will break. By moving the new member at the end of the struct, this should not be a problem.


This is an automatic backport of pull request #3001 done by Mergify.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.37%. Comparing base (4bdd622) to head (409cd51).
⚠️ Report is 1 commits behind head on kilted.

Additional details and impacted files
@@            Coverage Diff             @@
##           kilted    #3003      +/-   ##
==========================================
- Coverage   89.37%   89.37%   -0.01%     
==========================================
  Files         157      157              
  Lines       18791    18789       -2     
  Branches     1511     1510       -1     
==========================================
- Hits        16795    16792       -3     
- Misses       1375     1376       +1     
  Partials      621      621              
Flag Coverage Δ
unittests 89.37% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/include/hardware_interface/hardware_info.hpp 98.78% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 79255d6 into kilted Jan 29, 2026
14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-3001 branch January 29, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant