Skip to content

Conversation

@destogl
Copy link
Member

@destogl destogl commented Jan 30, 2026

Fixes #3004
The demo for testing is in ros-controls/ros2_control_demos#1028

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.40%. Comparing base (5667d80) to head (506361b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3006   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files         157      157           
  Lines       18781    18783    +2     
  Branches     1510     1510           
=======================================
+ Hits        16791    16793    +2     
  Misses       1369     1369           
  Partials      621      621           
Flag Coverage Δ
unittests 89.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...are_interface/src/hardware_component_interface.cpp 81.46% <100.00%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suppose this fixes the reported issue.

For reference, we have to work on passing node arguments (especially remappings) to the hardware nodes, see #2144

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works like a charm. Tested it with the example_2 + tried to add a publisher to the HW component and also tried to remap it from the ros2_control_node and it is working quite good

@saikishor saikishor merged commit 6ae1df6 into master Feb 3, 2026
18 of 45 checks passed
@saikishor saikishor deleted the hotfix/no-name-overlapping-of-cm-when-custom branch February 3, 2026 09:31
@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Feb 3, 2026
mergify bot pushed a commit that referenced this pull request Feb 3, 2026
mergify bot pushed a commit that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overriding node options for CM when the name is set in the launch file?

3 participants