-
Notifications
You must be signed in to change notification settings - Fork 402
Fix the node name overlapping. #3006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the node name overlapping. #3006
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3006 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 157 157
Lines 18781 18783 +2
Branches 1510 1510
=======================================
+ Hits 16791 16793 +2
Misses 1369 1369
Partials 621 621
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I suppose this fixes the reported issue.
For reference, we have to work on passing node arguments (especially remappings) to the hardware nodes, see #2144
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works like a charm. Tested it with the example_2 + tried to add a publisher to the HW component and also tried to remap it from the ros2_control_node and it is working quite good
(cherry picked from commit 6ae1df6)
(cherry picked from commit 6ae1df6)
Fixes #3004
The demo for testing is in ros-controls/ros2_control_demos#1028