Fix PR template (#265)

* Fix PR template

* Fix links

* Add info to local tests

Author: christophfroehlich

.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

@@ -1,4 +1,3 @@
-
 ---
 name: Pull request
 about: Create a pull request
@@ -7,20 +6,13 @@ labels: ''
 assignees: ''
 
 ---
+## General
+Please consider the infos from [CONTRIBUTING.md](CONTRIBUTING.md) before you open a pull request.
+## New Examples
+If you propose addign a new example, make sure that your new example has:
 
-Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
-
-1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
-2. Give your PR a descriptive title. Add a short summary, if required.
-3. Make sure the pipeline is green.
-4. Don’t be afraid to request reviews from maintainers.
-5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.
-
-To send us a pull request, please:
-
-- [ ] Fork the repository.
-- [ ] Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
-- [ ] Ensure local tests pass. (`colcon test` and `pre-commit run` (requires you to install pre-commit by `pip3 install pre-commit`)
-- [ ] Commit to your fork using clear commit messages.
-- [ ] Send a pull request, answering any default questions in the pull request interface.
-- [ ] Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
+- [ ] The correct folder structure (described in the main [README.md](README.md))
+- [ ] Example has *doc/README.rst* with description
+- [ ] Detailed commands how to run an example
+- [ ] Output examples of CLI commands
+- [ ] Screenshots with expected visualizations (if applicable)

CONTRIBUTING.md

@@ -33,7 +33,7 @@ To send us a pull request, please:
 1. Fork the repository.
 2. Modify the source; please focus on the specific change you are contributing.
   If you also reformat all the code, it will be hard for us to focus on your change.
-3. Ensure local tests pass.
+3. Ensure local tests pass: `colcon test` and `pre-commit run` (requires you to install pre-commit by `pip3 install pre-commit`).
 4. Commit to your fork using clear commit messages.
 5. Send a pull request, answering any default questions in the pull request interface.
 6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.