Skip to content

Commit 26b37b6

Browse files
committed
chained_filter, diff_drive, effort, forward_command, etc files update with controller_interface migration
1 parent fce9bae commit 26b37b6

File tree

24 files changed

+383
-92
lines changed

24 files changed

+383
-92
lines changed

chained_filter_controller/test/test_chained_filter.cpp

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,13 @@ void ChainedFilterTest::SetUpController(
4848
auto node_options = controller_->define_custom_node_options();
4949
node_options.parameter_overrides(parameters);
5050

51-
const auto result = controller_->init(node_name, "", 0, "", node_options);
51+
controller_interface::ControllerInterfaceParams params;
52+
params.controller_name = node_name;
53+
params.robot_description = "";
54+
params.update_rate = 0;
55+
params.node_namespace = "";
56+
params.node_options = node_options;
57+
const auto result = controller_->init(params);
5258
ASSERT_EQ(result, controller_interface::return_type::OK);
5359

5460
std::vector<LoanedStateInterface> state_ifs;
@@ -61,8 +67,13 @@ TEST_F(ChainedFilterTest, InitReturnsSuccess) { SetUpController(); }
6167

6268
TEST_F(ChainedFilterTest, InitFailureWithNoParams)
6369
{
64-
const auto result = controller_->init(
65-
"test_chained_filter_no_params", "", 0, "", controller_->define_custom_node_options());
70+
controller_interface::ControllerInterfaceParams params;
71+
params.controller_name = "test_chained_filter_no_params";
72+
params.robot_description = "";
73+
params.update_rate = 0;
74+
params.node_namespace = "";
75+
params.node_options = controller_->define_custom_node_options();
76+
const auto result = controller_->init(params);
6677
EXPECT_EQ(result, controller_interface::return_type::ERROR);
6778
}
6879

chained_filter_controller/test/test_multiple_chained_filter.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,13 @@ void MultipleChainedFilterTest::SetUpController(
4848
auto node_options = controller_->define_custom_node_options();
4949
node_options.parameter_overrides(parameters);
5050

51-
const auto result = controller_->init(node_name, "", 0, "", node_options);
51+
controller_interface::ControllerInterfaceParams params;
52+
params.controller_name = node_name;
53+
params.robot_description = "";
54+
params.update_rate = 0;
55+
params.node_namespace = "";
56+
params.node_options = node_options;
57+
const auto result = controller_->init(params);
5258
ASSERT_EQ(result, controller_interface::return_type::OK);
5359

5460
std::vector<LoanedStateInterface> state_ifs;

diff_drive_controller/test/test_diff_drive_controller.cpp

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,13 @@ class TestDiffDriveController : public ::testing::Test
206206

207207
parameter_overrides.insert(parameter_overrides.end(), parameters.begin(), parameters.end());
208208
node_options.parameter_overrides(parameter_overrides);
209-
210-
return controller_->init(controller_name, urdf_, 0, ns, node_options);
209+
controller_interface::ControllerInterfaceParams params;
210+
params.controller_name = controller_name;
211+
params.robot_description = urdf_;
212+
params.update_rate = 0;
213+
params.node_namespace = ns;
214+
params.node_options = node_options
215+
return controller_->init(params);
211216
}
212217

213218
std::string controller_name;
@@ -243,8 +248,14 @@ class TestDiffDriveController : public ::testing::Test
243248

244249
TEST_F(TestDiffDriveController, init_fails_without_parameters)
245250
{
251+
controller_interface::ControllerInterfaceParams params;
252+
params.controller_name = controller_name;
253+
params.robot_description = urdf_;
254+
params.update_rate = 0;
255+
params.node_namespace = "";
256+
params.node_options = controller_->define_custom_node_options();
246257
const auto ret =
247-
controller_->init(controller_name, urdf_, 0, "", controller_->define_custom_node_options());
258+
controller_->init(params);
248259
ASSERT_EQ(ret, controller_interface::return_type::ERROR);
249260
}
250261

effort_controllers/test/test_joint_group_effort_controller.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,13 @@ void JointGroupEffortControllerTest::SetUpController(
4242
auto node_options = controller_->define_custom_node_options();
4343
node_options.parameter_overrides(parameters);
4444

45-
const auto result =
46-
controller_->init("test_joint_group_effort_controller", "", 0, "", node_options);
45+
controller_interface::ControllerInterfaceParams params;
46+
params.controller_name = "test_joint_group_effort_controller";
47+
params.robot_description = "";
48+
params.update_rate = 0;
49+
params.node_namespace = "";
50+
params.node_options = node_options;
51+
const auto result = controller_->init(params);
4752
ASSERT_EQ(result, controller_interface::return_type::OK);
4853

4954
std::vector<LoanedCommandInterface> command_ifs;

force_torque_sensor_broadcaster/test/test_force_torque_sensor_broadcaster.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,14 @@ void ForceTorqueSensorBroadcasterTest::TearDown() { fts_broadcaster_.reset(nullp
5454

5555
void ForceTorqueSensorBroadcasterTest::SetUpFTSBroadcaster(std::string node_name)
5656
{
57+
controller_interface::ControllerInterfaceParams params;
58+
params.controller_name = node_name;
59+
params.robot_description = "";
60+
params.update_rate = 0;
61+
params.node_namespace = "";
62+
params.node_options = fts_broadcaster_->define_custom_node_options();
5763
const auto result =
58-
fts_broadcaster_->init(node_name, "", 0, "", fts_broadcaster_->define_custom_node_options());
64+
fts_broadcaster_->init(params);
5965
ASSERT_EQ(result, controller_interface::return_type::OK);
6066

6167
std::vector<LoanedStateInterface> state_ifs;

forward_command_controller/test/test_forward_command_controller.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,13 @@ void ForwardCommandControllerTest::SetUpController(
5454
{
5555
auto node_options = controller_->define_custom_node_options();
5656
node_options.parameter_overrides(parameters);
57-
58-
const auto result = controller_->init("forward_command_controller", "", 0, "", node_options);
57+
controller_interface::ControllerInterfaceParams params;
58+
params.controller_name = "forward_command_controller";
59+
params.robot_description = "";
60+
params.update_rate = 0;
61+
params.node_namespace = "";
62+
params.node_options = node_options;
63+
const auto result = controller_->init(params);
5964
ASSERT_EQ(result, controller_interface::return_type::OK);
6065

6166
std::vector<LoanedCommandInterface> command_ifs;

forward_command_controller/test/test_multi_interface_forward_command_controller.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,14 @@ void MultiInterfaceForwardCommandControllerTest::SetUpController(
6565
auto node_options = controller_->define_custom_node_options();
6666
node_options.parameter_overrides(parameter_overrides);
6767

68+
controller_interface::ControllerInterfaceParams params;
69+
params.controller_name = "multi_interface_forward_command_controller";
70+
params.robot_description = "";
71+
params.update_rate = 0;
72+
params.node_namespace = "";
73+
params.node_options = node_options;
6874
const auto result =
69-
controller_->init("multi_interface_forward_command_controller", "", 0, "", node_options);
75+
controller_->init(params);
7076
ASSERT_EQ(result, controller_interface::return_type::OK);
7177

7278
std::vector<LoanedCommandInterface> command_ifs;

0 commit comments

Comments
 (0)