Skip to content

Commit b677091

Browse files
committed
Merge branch 'master' into diff-drive-chainable-1457
2 parents fe063fe + e0b929b commit b677091

File tree

55 files changed

+179
-51
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+179
-51
lines changed

ackermann_steering_controller/CHANGELOG.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22
Changelog for package ackermann_steering_controller
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
4.19.0 (2025-01-13)
6+
-------------------
7+
* Fix typos in steering_controllers_lib (`#1464 <https://github.com/ros-controls/ros2_controllers/issues/1464>`_)
8+
* Remove visibility macros (`#1451 <https://github.com/ros-controls/ros2_controllers/issues/1451>`_)
9+
* Contributors: Bence Magyar, Christoph Fröhlich
10+
511
4.18.0 (2024-12-19)
612
-------------------
713

ackermann_steering_controller/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
33
<package format="3">
44
<name>ackermann_steering_controller</name>
5-
<version>4.18.0</version>
5+
<version>4.19.0</version>
66
<description>Steering controller for Ackermann kinematics. Rear fixed wheels are powering the vehicle and front wheels are steering it.</description>
77

88
<maintainer email="[email protected]">Bence Magyar</maintainer>

admittance_controller/CHANGELOG.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
Changelog for package admittance_controller
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
4.19.0 (2025-01-13)
6+
-------------------
7+
* Remove visibility macros (`#1451 <https://github.com/ros-controls/ros2_controllers/issues/1451>`_)
8+
* Contributors: Bence Magyar
9+
510
4.18.0 (2024-12-19)
611
-------------------
712
* [CI] Add clang job and setup concurrency (`#1407 <https://github.com/ros-controls/ros2_controllers/issues/1407>`_)

admittance_controller/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
33
<package format="3">
44
<name>admittance_controller</name>
5-
<version>4.18.0</version>
5+
<version>4.19.0</version>
66
<description>Implementation of admittance controllers for different input and output interface.</description>
77

88
<maintainer email="[email protected]">Bence Magyar</maintainer>

bicycle_steering_controller/CHANGELOG.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22
Changelog for package bicycle_steering_controller
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
4.19.0 (2025-01-13)
6+
-------------------
7+
* Fix typos in steering_controllers_lib (`#1464 <https://github.com/ros-controls/ros2_controllers/issues/1464>`_)
8+
* Remove visibility macros (`#1451 <https://github.com/ros-controls/ros2_controllers/issues/1451>`_)
9+
* Contributors: Bence Magyar, Christoph Fröhlich
10+
511
4.18.0 (2024-12-19)
612
-------------------
713

bicycle_steering_controller/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
33
<package format="3">
44
<name>bicycle_steering_controller</name>
5-
<version>4.18.0</version>
5+
<version>4.19.0</version>
66
<description>Steering controller with bicycle kinematics. Rear fixed wheel is powering the vehicle and front wheel is steering.</description>
77

88
<maintainer email="[email protected]">Bence Magyar</maintainer>

diff_drive_controller/CHANGELOG.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22
Changelog for package diff_drive_controller
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
4.19.0 (2025-01-13)
6+
-------------------
7+
* Check dt in updateFromVelocity (`#1481 <https://github.com/ros-controls/ros2_controllers/issues/1481>`_)
8+
* Remove empty on_shutdown() callbacks (`#1477 <https://github.com/ros-controls/ros2_controllers/issues/1477>`_)
9+
* Remove visibility macros (`#1451 <https://github.com/ros-controls/ros2_controllers/issues/1451>`_)
10+
* Contributors: Bence Magyar, Julia Jia, Tony Najjar
11+
512
4.18.0 (2024-12-19)
613
-------------------
714
* Update command limiter of diff_drive_controller (`#1315 <https://github.com/ros-controls/ros2_controllers/issues/1315>`_)

diff_drive_controller/include/diff_drive_controller/diff_drive_controller.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ class DiffDriveController : public controller_interface::ChainableControllerInte
126126

127127
std::queue<std::array<double, 2>> previous_two_commands_;
128128
// speed limiters
129-
SpeedLimiter limiter_linear_;
130-
SpeedLimiter limiter_angular_;
129+
std::unique_ptr<SpeedLimiter> limiter_linear_;
130+
std::unique_ptr<SpeedLimiter> limiter_angular_;
131131

132132
bool publish_limited_velocity_ = false;
133133
std::shared_ptr<rclcpp::Publisher<TwistStamped>> limited_velocity_publisher_ = nullptr;

diff_drive_controller/include/diff_drive_controller/speed_limiter.hpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class SpeedLimiter
4040
* \param [in] min_jerk Minimum jerk [m/s^3], usually <= 0
4141
* \param [in] max_jerk Maximum jerk [m/s^3], usually >= 0
4242
*/
43-
[[deprecated]] SpeedLimiter(
43+
[[deprecated]] explicit SpeedLimiter(
4444
bool has_velocity_limits = true, bool has_acceleration_limits = true,
4545
bool has_jerk_limits = true, double min_velocity = std::numeric_limits<double>::quiet_NaN(),
4646
double max_velocity = std::numeric_limits<double>::quiet_NaN(),
@@ -79,16 +79,16 @@ class SpeedLimiter
7979
* >= 0
8080
* \param [in] min_jerk Minimum jerk [m/s^3], usually <= 0
8181
* \param [in] max_jerk Maximum jerk [m/s^3], usually >= 0
82+
*
83+
* \note
84+
* If max_* values are NAN, the respective limit is deactivated
85+
* If min_* values are NAN (unspecified), defaults to -max
86+
* If min_first_derivative_pos/max_first_derivative_neg values are NAN, symmetric limits are used
8287
*/
83-
SpeedLimiter(
84-
double min_velocity = std::numeric_limits<double>::quiet_NaN(),
85-
double max_velocity = std::numeric_limits<double>::quiet_NaN(),
86-
double max_acceleration_reverse = std::numeric_limits<double>::quiet_NaN(),
87-
double max_acceleration = std::numeric_limits<double>::quiet_NaN(),
88-
double max_deceleration = std::numeric_limits<double>::quiet_NaN(),
89-
double max_deceleration_reverse = std::numeric_limits<double>::quiet_NaN(),
90-
double min_jerk = std::numeric_limits<double>::quiet_NaN(),
91-
double max_jerk = std::numeric_limits<double>::quiet_NaN())
88+
explicit SpeedLimiter(
89+
double min_velocity, double max_velocity, double max_acceleration_reverse,
90+
double max_acceleration, double max_deceleration, double max_deceleration_reverse,
91+
double min_jerk, double max_jerk)
9292
{
9393
speed_limiter_ = control_toolbox::RateLimiter<double>(
9494
min_velocity, max_velocity, max_acceleration_reverse, max_acceleration, max_deceleration,

diff_drive_controller/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0"?>
22
<package format="3">
33
<name>diff_drive_controller</name>
4-
<version>4.18.0</version>
4+
<version>4.19.0</version>
55
<description>Controller for a differential-drive mobile base.</description>
66

77
<maintainer email="[email protected]">Bence Magyar</maintainer>

0 commit comments

Comments
 (0)