fix node args used to launch joy nodes via launch file#309
Open
andreas-loeffler wants to merge 1 commit intoros-drivers:ros2from
Open
fix node args used to launch joy nodes via launch file#309andreas-loeffler wants to merge 1 commit intoros-drivers:ros2from
andreas-loeffler wants to merge 1 commit intoros-drivers:ros2from
Conversation
Signed-off-by: Andreas Loeffler <73336148+andreas-loeffler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX
This PR is fixing the usage of the ComposableNode and Node arguments to work under ros2 jazzy and rolling, by removing the outdated node_ prefix for the class arguments