Fix subscribe/unsubscribe behavior #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machinekoder
force-pushed
the
fix-unsubscribe
branch
from
261a6db to
8ab22a5
Compare
machinekoder
force-pushed
the
fix-unsubscribe
branch
from
8ab22a5 to
77b24fe
Compare
Contributor
Author
|
@awesomebytes Rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the subscribe/unsubscribe behavior of the node, especially when the camera errors out or is disconnected.
In our setup we enable
ar_track_alvaron demand (subscribes/unsubscribes), this enables hot-plugging of the camera devices and better error recovery.