Planning Constraints from MoveIt Request#62
Open
Jmeyer1292 wants to merge 5 commits intoros-industrial-attic:indigo-develfrom
Open
Planning Constraints from MoveIt Request#62Jmeyer1292 wants to merge 5 commits intoros-industrial-attic:indigo-develfrom
Jmeyer1292 wants to merge 5 commits intoros-industrial-attic:indigo-develfrom
Conversation
added 5 commits
October 13, 2017 10:11
…ints and does not immediately install them
…s from ROS params and loading extra constraints via user request constraints.
… in the goal and no pose constraints are loaded via defaults.
Contributor
|
Thanks for the contribution, it's not clear to me why the build fails. |
Contributor
Author
|
It appears to build, but the unit tests are failing: Specifically, the |
jrgnicho
reviewed
Sep 10, 2018
Contributor
jrgnicho
left a comment
jrgnicho
left a comment
There was a problem hiding this comment.
There are a few TODOs here and there,
@Jmeyer1292 were you planning to make any further changes here?
|
|
||
| GoalOrientation(); | ||
|
|
||
| virtual unsigned constraintType() const |
Contributor
There was a problem hiding this comment.
I'd prefer to drop the virtual and use override instead.
| // Constraint additions | ||
| std::vector<std::pair<bool, Constraint*> > resolveConstraints() const; | ||
|
|
||
| Constraint* createConstraint(const moveit_msgs::PositionConstraint& pos_constraint) const; |
Contributor
There was a problem hiding this comment.
Would it not be safer (memory-wise) to return smart pointers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR needs some documentation work.
The general idea is that we load constraint plugins from the YAML file and store them as
default_constraints. Added to the base class is an integer field flag list that indicates if the given plugin constraints position or orientation.If the user specifies goal constraints that also constraint position or orientation, those are used IN PLACE of the defaults.