fix on CMakeFiles to let the package compile in Windows 10 - ROS Noetic #53
Open
enricovillagrossi wants to merge 3 commits intoros-industrial:masterfrom
Open
fix on CMakeFiles to let the package compile in Windows 10 - ROS Noetic #53enricovillagrossi wants to merge 3 commits intoros-industrial:masterfrom
enricovillagrossi wants to merge 3 commits intoros-industrial:masterfrom
Conversation
gavanderhoorn
requested changes
Sep 5, 2022
Member
gavanderhoorn
left a comment
gavanderhoorn
left a comment
There was a problem hiding this comment.
Thanks for the PR, and my apologies for the delayed review.
Could we perhaps use target_compile_definitions(..) instead?
Member
|
Annoying we don't have Windows CI here (#3). (this is not directed at you @enricovillagrossi, just a mental note) |
…options to let the packages compile on Windows
Author
|
@gavanderhoorn I moved the flag -DNOGDI in target_compile_definitions(...). Let me know if it is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #17 I modified the CMakeFile to let the package compile on Windows 10 and ROS Noetic.
This is ready for review and any feedback would be appreciated!