Added support for KEYRING storage of the password of ROSDEP#895
Open
progtologist wants to merge 3 commits intoros-infrastructure:cottsay/auth_urlsfrom
Open
Added support for KEYRING storage of the password of ROSDEP#895progtologist wants to merge 3 commits intoros-infrastructure:cottsay/auth_urlsfrom
progtologist wants to merge 3 commits intoros-infrastructure:cottsay/auth_urlsfrom
Conversation
Codecov ReportBase: 74.89% // Head: 74.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## cottsay/auth_urls #895 +/- ##
=====================================================
- Coverage 74.89% 74.83% -0.07%
=====================================================
Files 44 44
Lines 3374 3389 +15
=====================================================
+ Hits 2527 2536 +9
- Misses 847 853 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some initial testing with both python2 and python3 but I cannot vouch 100% about the compatibility of everything. If we can get a publicly accessible authorized rosdep server I can write proper unit tests for everything.
I also took a shot at documenting this!