Skip to content

Fix handling of duplicate dependencies #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valgur wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix handling of duplicate dependencies #902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/rosdep2/dependency_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

# Author William Woodall/wjwwood@gmail.com

from collections import defaultdict
from collections import defaultdict, OrderedDict


class Resolution(dict):
Expand Down Expand Up @@ -130,7 +130,14 @@ def get_ordered_dependency_list(self):
squashed_result.append((installer_key, []))
previous_installer_key = installer_key
squashed_result[-1][1].extend(resolved)
return squashed_result
# Remove duplicate keys
deduplicated_result = []
for installer_key, install_keys in squashed_result:
deduplicated_result.append((
installer_key,
list(OrderedDict.fromkeys(install_keys))
))
return deduplicated_result

def __get_ordered_uninstalled(self, key):
uninstalled = []
Expand Down