Stop destroying table with change of distro#493
Stop destroying table with change of distro#493rkent wants to merge 1 commit intoros-infrastructure:ros2from
Conversation
|
I changed this to a draft, because I want to think it over. The issue is that it works TOO well. That is, you change repos, and there is sometimes no visible change to the displayed table. So you cannot tell the difference between a failed or slow repo update, and usable results. |
|
Yeah, if the versions are close enough there wont' be much difference in the results. I guess the optimal for that would be to have an indicator of the distro filtered inside the table that gets rendered. There's a few options:
Reflecting on those first impressions I think that a better one might be to have the full search parameters rendered on the top line in the table. |
I didn't like the way that the table flashes away briefly when changing distros. This solves that.
There was an issue that destroying and rebuilding the table solved, and that was to fix the distro fragment reference on the repo column (and group header). But I found another way to solve that, using the global gDistro. You can check that the links in the repo column point to the correct distro.
I also found the Tabulator blockRedraw function, which is used here to stop multiple table redraws when we are changing multiple things.
I have not been able to duplicate the previous issue I had seen with an occasional blank table after a search. Maybe it's gone? In any case, if it is rare, I think that getting rid of the table flash on distro change is worth the occasional glitch, if it still occurs.