Upgrade CSS from bootstrap 3 to bootstrap 5#627
Draft
rkent wants to merge 1 commit intoros-infrastructure:ros2from
Draft
Upgrade CSS from bootstrap 3 to bootstrap 5#627rkent wants to merge 1 commit intoros-infrastructure:ros2from
rkent wants to merge 1 commit intoros-infrastructure:ros2from
Conversation
Signed-off-by: R Kent James <kent@caspia.com> Generated-by: This entire commit was generated from github.copilot using claude opus 4.5
Member
|
Yeah, on initial testing things generally work, but it's got some rough edges. I"m trying it out from the artifact generated in the action I see two missing resources on the hosting log The colors appear to have been unmapped more to a default, and the spacing appears to be lost; 
Versus 
And some of the styling is also lost 
The chips and stuff look to have lost their styling too both color and size 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-by: This entire commit was generated from github.copilot using claude opus 4.5
rosindex uses the long-obsolete bootstrap 3 instead of bootstrap 5. Today I asked claude opus 4.5 to 1) plan then 2) implement an upgrade. This is the result, with no changes done by me to the code.
With a quick overview, AFAICT it works fine, though there are some visual changes I would do before asking it to be released. I have idea how we would review a massive change like this other than a visual comparison of the results.