Skip to content

Conversation

@berndpfrommer
Copy link
Collaborator

@berndpfrommer berndpfrommer commented Aug 6, 2025

This PR:

  • adopts the new ffmpeg_encoder_api from this PR which allows for probing of decoders. The decoder parameter can now contain a list of comma-separated decoders which will be tried in order.
  • adds tests to the repo
  • reformats to the black python formatter
  • adds arguments to some example launch files
  • allows arbitrary AVOptions setting via av_option
  • removes parameters "preset", "tune", "delay", and "crf" (must now be set via "av_options")
  • removes some default values (like bit_rate) to force user to set them explicitly
  • changes the parameter names: remove the leading ".", so now the parameters are named specify "camera.image_raw.." as opposed to ".camera.image_raw..."

Copy link

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, neat. Testing locally.

@berndpfrommer berndpfrommer force-pushed the support_fallback_decoder branch from a8d42d6 to d0747dd Compare August 7, 2025 21:08
@berndpfrommer berndpfrommer merged commit 8b3b574 into master Aug 8, 2025
3 of 6 checks passed
@berndpfrommer berndpfrommer deleted the support_fallback_decoder branch August 8, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants