Skip to content

Create iterator for custom height field in pointcloud. #5586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Create iterator for custom height field in pointcloud. #5586

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5860a27
Create iterator for custom height field in pointcloud.
greganderson-vermeer Oct 6, 2025
7e6ccc9
Add use_global_height_ parameter to allow configuration
greganderson-vermeer Oct 7, 2025
ca49b05
Ran ament lint/style tools, cleaned up.
greganderson-vermeer Oct 7, 2025
11f04c7
Added some pointcloud field checking based on run time
greganderson-vermeer Oct 7, 2025
869b5a9
Address PR formatting feedback.
greganderson-vermeer Oct 7, 2025
1cdbc05
Add return false for error state.
greganderson-vermeer Oct 7, 2025
b2fbb06
Implemented additional changes for iterator feedback
greganderson-vermeer Oct 7, 2025
5636fc1
Implementing Steve's suggestion for performance and
greganderson-vermeer Oct 7, 2025
aa2cdc5
Apply suggestions from code review
greganderson-vermeer Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nav2_collision_monitor/src/pointcloud.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,12 @@ bool PointCloud::getData(
sensor_msgs::PointCloud2ConstIterator<float> iter_x(*data_, "x");
sensor_msgs::PointCloud2ConstIterator<float> iter_y(*data_, "y");
sensor_msgs::PointCloud2ConstIterator<float> iter_z(*data_, "z");
sensor_msgs::PointCloud2ConstIterator<float> iter_height(*data_, "height");

// Refill data array with PointCloud points in base frame
for (; iter_x != iter_x.end(); ++iter_x, ++iter_y, ++iter_z) {
for (; iter_x != iter_x.end(); ++iter_x, ++iter_y, ++iter_z, ++iter_height) {
// Transform point coordinates from source frame -> to base frame
//Not transforming height since it is already relative to ground
tf2::Vector3 p_v3_s(*iter_x, *iter_y, *iter_z);

// Check range from sensor origin before transformation
Expand All @@ -120,7 +122,7 @@ bool PointCloud::getData(
tf2::Vector3 p_v3_b = tf_transform * p_v3_s;

// Refill data array
if (p_v3_b.z() >= min_height_ && p_v3_b.z() <= max_height_) {
if (*iter_height >= min_height_ && *iter_height <= max_height_) {
data.push_back({p_v3_b.x(), p_v3_b.y()});
}
}
Expand Down
Loading