Skip to content

Change service name/fromLL -> fromLL #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change service name/fromLL -> fromLL #5692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nav2_waypoint_follower/src/waypoint_follower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ WaypointFollower::on_configure(const rclcpp_lifecycle::State & state)
500), false);

from_ll_to_map_client_ = node->create_client<robot_localization::srv::FromLL>(
"/fromLL",
"fromLL",
Copy link
Member

@SteveMacenski SteveMacenski Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this is that then the service will be placed under a namespace that the waypoint follower node is placed in -- not the namespace that potentially the robot localization node is. I think this may be better to be remapped in your launch file from /fromLL -> /my_rl_ns/fromLL that way you explicitly control what namespace this is applied to. There's no reason to expect that the namespace of the WPF will be the same as RL - especially if you consider that many GPS applications may have 2 or 3 RL instances that could either be named uniquely or namespaced uniquely - separate of the application namespace itself.

true /*creates and spins an internal executor*/);

gps_action_server_ = create_action_server<ActionTGPS>(
Expand Down
Loading