[video_recorder] Add timer to record low fps video at the correct speed#600
Open
708yamaguchi wants to merge 3 commits intoros-perception:melodicfrom
Open
[video_recorder] Add timer to record low fps video at the correct speed#600708yamaguchi wants to merge 3 commits intoros-perception:melodicfrom
708yamaguchi wants to merge 3 commits intoros-perception:melodicfrom
Conversation
JWhitleyWork
requested changes
Oct 8, 2020
Collaborator
JWhitleyWork
left a comment
JWhitleyWork
left a comment
There was a problem hiding this comment.
In general, I'm OK with this feature. Just needs some tweaks.
| outputVideo << image; | ||
| ROS_INFO_STREAM("Recording frame " << g_count << "\x1b[1F"); | ||
| g_count++; | ||
| g_last_wrote_time = stamp; |
Collaborator
There was a problem hiding this comment.
This is no longer true. The timestamp of the last-received image can no longer be considered close enough to the actual time that the frame was written. Use ros::Time::now() instead.
|
|
||
| if ((image_msg->header.stamp - g_last_wrote_time) < ros::Duration(1.0 / fps)) | ||
| stamp = image_msg->header.stamp; | ||
| if ((stamp - g_last_wrote_time) < ros::Duration(1.0 / fps)) |
Collaborator
There was a problem hiding this comment.
This change is unnecessary given my other comment.
Author
|
Thank you for your review. I followed your advice and use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this pull request, when we record video with lower fps than
fpsrosparam, the output video will be fast and shortened.For example, if we set
fpsrosparam as 15 but inputsensor_msgs::Imagetopic's hz is 5 and we record video for 30 seconds, the output video is only 10 seconds and 3x speed.This pull request solves the above problem by using timer callback and outputting video at regular intervals.