Export target in the modern way #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Jul 22, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
I would prefer the suggested patch instead of this one.
Contributor
Author
|
Agreed! Will work on it |
ahcorde
requested changes
Jul 28, 2025
Contributor
Author
|
Failing because of #201 |
Signed-off-by: Patrick Roncagliolo <[email protected]>
ahcorde
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to maintainers: my take on this is that we should split in two libraries: one containing encoder/decoder(s) and the other the image_transport plugin. Then, only the first library should be exported.
Let me know if you want such development, I can push an updated patch. And then, I can do it for the other packages in this same repo.