Open
Conversation
Member
|
Thanks for the contribution @jkaniuka! I am a bit short on time, but will try to find some over the next few weeks to look into this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hi, I have been using PyBullet in my engineering thesis and recently noticed that you have made the ROS-PyBullet Interface code available. I was very comfortable using Pybullet, but at the time I was surprised why it was not available as a ROS package. I see that the ROS 2 branch is in early development, so I decided to add something from myself.
Description
I took care of the GUI implementation in the form of the rqt plugin. The reference point for me was the rpbi_controls_node.py file from
mainbranch of ros_pybullet_interface repository.robot_nameparameter is used when handling the press event of this button. In ROS 2 the concept of parameters has been completely changed. There is no global parameter anymore. Each parameter is specific to a node. This issue requires careful consideration.Screenshot
How to run
ros_pybullet_rqt_pluginpackage and source setup file.rqtcommand) and navigate to Plugins ➡️ Introspection ➡️ PyBullet Interface Controls-s(standalone) flagMy setup
Tools used in the development
How to test
You can test whether the status information is displayed correctly by publishing a message on the
rpbi/statustopic.