Open
Conversation
Member
Author
|
I added these changes with @k1631364, so that we can change the parameters online. We want to extend this to also change the parameters of the robot link. Do you have any suggestions where you would like this functionality to be placed? Let's maybe try to get this pull request through and then extend the functionality in another pull request, but you can leave here your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two ros services for:
Note that we exposed only the dynamic properties that we can both read and write using pybullet.
This was such that the message for getting and changing the parameters would be the same.
If we want to allow the user to get and change different sets of parameters, we have to think about different message system.