Conversation
|
Not sure if we want to wait for the setup-ros-docker Kilted images. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
- Coverage 26.08% 25.15% -0.94%
==========================================
Files 2 2
Lines 322 322
Branches 86 86
==========================================
- Hits 84 81 -3
- Misses 238 241 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelOrlov
left a comment
There was a problem hiding this comment.
LGTM. However, curious why so many CI jobs a re red?
|
macOS jobs have been failing for some time and I don't have time to fix them. Other than that, this needs to wait for |
|
ros-tooling/setup-ros#804 and ros-tooling/setup-ros-docker#82 were merged, so re-triggering CI here. |
8b9b07b to
a7abb29
Compare
|
CI is failing because the |
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
a7abb29 to
c9eb9ba
Compare
|
Alright, this is ready. The macOS jobs are failing for unrelated reasons. |
|
Released as |
Similar to #863, which did the same for Jazzy.
We need to use the testing apt repo to get Kilted binaries for tests before Kilted is officially released. See: https://docs.ros.org/en/kilted/Installation/Ubuntu-Install-Debians.html#enable-required-repositories. Once Kilted has been released, we can revert this.
Users will need to use
use-ros2-testing: truefor Kilted.Requires ros-tooling/setup-ros#804
Requires ros-tooling/setup-ros-docker#82