Skip to content

Add support for Kilted#966

Merged
christophebedard merged 1 commit intomasterfrom
christophebedard/kilted
May 2, 2025
Merged

Add support for Kilted#966
christophebedard merged 1 commit intomasterfrom
christophebedard/kilted

Conversation

@christophebedard
Copy link
Copy Markdown
Member

@christophebedard christophebedard commented May 1, 2025

Similar to #863, which did the same for Jazzy.

We need to use the testing apt repo to get Kilted binaries for tests before Kilted is officially released. See: https://docs.ros.org/en/kilted/Installation/Ubuntu-Install-Debians.html#enable-required-repositories. Once Kilted has been released, we can revert this.

Users will need to use use-ros2-testing: true for Kilted.

Requires ros-tooling/setup-ros#804
Requires ros-tooling/setup-ros-docker#82

@christophebedard christophebedard requested a review from a team as a code owner May 1, 2025 16:45
@christophebedard christophebedard requested review from MichaelOrlov and emersonknapp and removed request for a team May 1, 2025 16:45
@christophebedard
Copy link
Copy Markdown
Member Author

Not sure if we want to wait for the setup-ros-docker Kilted images.

@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.15%. Comparing base (c30d4b4) to head (8b9b07b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
- Coverage   26.08%   25.15%   -0.94%     
==========================================
  Files           2        2              
  Lines         322      322              
  Branches       86       86              
==========================================
- Hits           84       81       -3     
- Misses        238      241       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, curious why so many CI jobs a re red?

@christophebedard
Copy link
Copy Markdown
Member Author

macOS jobs have been failing for some time and I don't have time to fix them.

Other than that, this needs to wait for setup-ros and setup-ros-docker to be updated for Kilted.

@christophebedard
Copy link
Copy Markdown
Member Author

ros-tooling/setup-ros#804 and ros-tooling/setup-ros-docker#82 were merged, so re-triggering CI here.

@christophebedard christophebedard force-pushed the christophebedard/kilted branch from 8b9b07b to a7abb29 Compare May 1, 2025 20:20
@christophebedard
Copy link
Copy Markdown
Member Author

CI is failing because the rostooling/setup-ros-docker:ubuntu-noble-ros-kilted-ros-base-latest image is not available: ros-tooling/setup-ros-docker#82 (comment)

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard force-pushed the christophebedard/kilted branch from a7abb29 to c9eb9ba Compare May 2, 2025 16:56
@christophebedard
Copy link
Copy Markdown
Member Author

Alright, this is ready. The macOS jobs are failing for unrelated reasons.

@christophebedard christophebedard merged commit 9e55620 into master May 2, 2025
34 of 43 checks passed
@christophebedard christophebedard deleted the christophebedard/kilted branch May 2, 2025 17:57
@christophebedard
Copy link
Copy Markdown
Member Author

Released as 0.4.3/v0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants