Skip to content

Update design document with changes in signals handling#49

Merged
christophebedard merged 2 commits intorollingfrom
morlov/update_design_doc_with_sigint_handler
Jul 10, 2025
Merged

Update design document with changes in signals handling#49
christophebedard merged 2 commits intorollingfrom
morlov/update_design_doc_with_sigint_handler

Conversation

@MichaelOrlov
Copy link
Copy Markdown
Member

@MichaelOrlov MichaelOrlov commented Jul 9, 2025

@MichaelOrlov @morlov-apexai
Update design document with changes in signals handling
417cb65 
- Follow-up on #10

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner July 9, 2025 22:02
@MichaelOrlov MichaelOrlov requested review from christophebedard and emersonknapp and removed request for a team July 9, 2025 22:02
christophebedard
christophebedard approved these changes Jul 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

christophebedard
christophebedard approved these changes Jul 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MichaelOrlov
Copy link
Copy Markdown
Member Author

MichaelOrlov commented Jul 10, 2025

@christophebedard The CI Build and Test job is frozen, and I can't figure out why.
Please note that other dependabot PR also frozen the same way.

Could it be that something is wrong with the ghcr.io docker images?
Could you please help me figure out what is wrong?

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Jul 10, 2025

Can you just try amending your commit and force-pushing just to retrigger CI?

@MichaelOrlov
Copy link
Copy Markdown
Member Author

MichaelOrlov commented Jul 10, 2025

Can you just try amending your commit and force-pushing just to retrigger CI?

I can, but I have some doubts that it will help. Another hanging PR #40 has the same issue

@MichaelOrlov @morlov-apexai
Address review comment
0c29843 
- Replaced `handle_sigint` to the `install_signal_handler`

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the morlov/update_design_doc_with_sigint_handler branch from dcc42e8 to 0c29843 Compare July 10, 2025 17:49
@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Jul 10, 2025 •
edited
Loading

I don't know why you think it might be related to Docker images, because I can't click on the build_and_test job. I can't get any info about it. The image seems to exist, though: https://github.com/ros-tooling/setup-ros-docker/pkgs/container/setup-ros-docker%2Fsetup-ros-docker-ubuntu-noble/406740411?tag=master

but what matters is ci.ros2.org anyway, not GitHub CI, so we can ignore it and just run CI with ci.ros2.org

@MichaelOrlov
Copy link
Copy Markdown
Member Author

MichaelOrlov commented Jul 10, 2025

but what matters is ci.ros2.org anyway, not GitHub CI, so we can ignore it and just run CI with ci.ros2.org

First of all, it doesn't make sense to run CI with ci.ros2.org since changes only in the design document.
The second, is that squash and merge button inactive untill build_and_test will succed.
image

@christophebedard christophebedard merged commit 52836ef into rolling Jul 10, 2025
9 checks passed
@christophebedard christophebedard deleted the morlov/update_design_doc_with_sigint_handler branch July 10, 2025 20:22
@MichaelOrlov
Copy link
Copy Markdown
Member Author

MichaelOrlov commented Jul 27, 2025

https://github.com/Mergifyio backport kilted jazzy

@mergify
Copy link
Copy Markdown

mergify bot commented Jul 27, 2025 •
edited
Loading

backport kilted jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jul 27, 2025
@MichaelOrlov @mergify
Update design document with changes in signals handling (#49)
566429d 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 52836ef)
mergify bot pushed a commit that referenced this pull request Jul 27, 2025
@MichaelOrlov @mergify
Update design document with changes in signals handling (#49)
5546935 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 52836ef)
This was referenced Jul 27, 2025
Merged
Merged
christophebedard pushed a commit that referenced this pull request Oct 2, 2025
@mergify @MichaelOrlov
Update design document with changes in signals handling (#49) (#53)
3302998 
(cherry picked from commit 52836ef)

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: Michael Orlov <morlovmr@gmail.com>
christophebedard pushed a commit that referenced this pull request Oct 2, 2025
@mergify @MichaelOrlov
Update design document with changes in signals handling (#49) (#52)
b6c608e 
(cherry picked from commit 52836ef)

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros-tooling/reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaelOrlov @christophebedard