Update cargo-manifest

[skrobchik]

No description provided.

[skrobchik]

Seems to work correctly. I am still getting a build error with std_msgs, but that also happens on main branch if I set the edition to 2021.

error: failed to select a version for the requirement `std_msgs = "*"`
  version 4.2.3 is yanked

[skrobchik]

Nevermind, I have to build the entire ros2_rust project to test this properly. And for some reason CMake can't find Python 😠

CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python3 (missing: Python3_NumPy_INCLUDE_DIRS NumPy) (found
  version "3.12.3")
Call Stack (most recent call first):
  /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.28/Modules/FindPython/Support.cmake:3862 (find_package_handle_standard_args)
  /usr/share/cmake-3.28/Modules/FindPython3.cmake:545 (include)
  /opt/ros/jazzy/share/rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake:22 (find_package)
  /opt/ros/jazzy/share/ament_cmake_core/cmake/core/ament_execute_extensions.cmake:48 (include)
  /opt/ros/jazzy/share/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake:280 (ament_execute_extensions)
  CMakeLists.txt:16 (rosidl_generate_interfaces)

[skrobchik]

Ok, I removed everything and reinstalled colcon-cargo and colcon-ros-cargo as system packages in Ubuntu with --break-system-packages instead of venv.

Then installed cargo-ament-build with cargo from my local git repo.

Now it actually build, but there's some errors with the ros2_rust example.

[mxgrey]

Now it actually build, but there's some errors with the ros2_rust example.

If it's an error in the behavior then it may be related to ros2-rust/ros2_rust#463

[skrobchik]

I think the example in the tutorial may be outdated.

Anyways, I took one of the minimal examples and tried with it.

git switch -C ../cargo-ament-build main
cargo install --path ../cargo-ament-build
colcon build

Fails with

--- stderr: republisher_node                                                                                                           
Error in cargo-ament-build

Caused by:
    0: unknown variant `2024`, expected one of `2015`, `2018`, `2021` for key `package.edition` at line 6 column 1
    1: unknown variant `2024`, expected one of `2015`, `2018`, `2021` for key `package.edition` at line 6 column 1
---

With this patch

git switch -C ../cargo-ament-build up-manifest
cargo install --path ../cargo-ament-build
colcon build

The build completes successfully.

[skrobchik]

@esteve I think this should be good to merge. Can you please review it?

[esteve]

@skrobchik thanks!

[skrobchik]

Seems like macos job is stuck

[skrobchik]

@mxgrey @esteve Is there anything else required to get this merged?

[Guelakais]

Are you still there? Guys, the communication isn't going so well.

[esteve]

@skrobchik apologies for the delay, it looks like the CI was failing because the macOS 12 runner has been removed from GtiHub, I've submitted #24 and we'll merge it soon. Afterwards I'll rebase this PR and we can merge it. Thanks for the patience.

[esteve]

@skrobchik CI now passes, merging the changes. Thanks!