added nix development environment, Cargo.lock, edition update, dependency update#23
Closed
Guelakais wants to merge 5 commits intoros2-rust:mainfrom
Closed
added nix development environment, Cargo.lock, edition update, dependency update#23Guelakais wants to merge 5 commits intoros2-rust:mainfrom
Guelakais wants to merge 5 commits intoros2-rust:mainfrom
Conversation
Guelakais
force-pushed
the
main
branch
3 times, most recently
from
afaebdb to
16517e3
Compare
13 tasks
Guelakais
force-pushed
the
main
branch
2 times, most recently
from
4bdc809 to
a074259
Compare
Contributor
|
@Guelakais please avoid adding any changes that are unrelated to the goal of this PR. You mentioned that you're reenabling I've also seen the PR at NixOS/nixpkgs#398799 in the nixpkgs repository, my suggestion in general is that you should listen more to the maintainers of a project and not take feedback personally, not everyone has as much patience as we have demonstrated multiple times in this project. |
Guelakais
changed the title
Guelakais
changed the title
Guelakais
changed the title
Guelakais
force-pushed
the
main
branch
3 times, most recently
from
3dfa3b8 to
b78ff04
Compare
added rust-toolchain.toml for the nix flake The nix flake needs a rust-toolchain.toml to rely on
```rust
warning: the borrowed expression implements the required traits
--> src/lib.rs:149:23
|
149 | std::fs::copy(&src, &dest).with_context(|| {
| ^^^^ help: change this to: `src`
|
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by
default
warning: `cargo-ament-build` (lib) generated 1 warning (run `cargo
clippy --fix --lib -p cargo-ament-build` to apply 1 suggestion)
```
Guelakais
changed the title
Contributor
|
Closing this PR as the feedback hasn't been addressed and it hasn't been updated in a long time. @Guelakais please reopen or submit a new PR when you have addressed the feedback I gave you, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the added
flake.nixis there to be able to build this package in nix environments.A
Cargo.lockfile is urgently required for certain packet managers. Therefore, the corresponding entry in the.gitignorehas been removed to enable its generation.