build: rename generate_docs feature to use_ros_shim #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteve Fernandez <[email protected]>
jhdcs
approved these changes
Aug 8, 2025
Collaborator
jhdcs
left a comment
jhdcs
left a comment
There was a problem hiding this comment.
The changes appear fine to me, and it doesn't seem to bother CI at all. This should be good to merge.
Collaborator
Author
|
@jhdcs thanks for the prompt review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the
rclrscounterpart of ros2-rust/rosidl_runtime_rs#14, given that we'll use this feature for publishing the crate onto crates.io in addition to docs.rs,use_ros_shimmight make more sense.