Skip to content

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Aug 8, 2025

This PR is the rclrs counterpart of ros2-rust/rosidl_runtime_rs#14, given that we'll use this feature for publishing the crate onto crates.io in addition to docs.rs, use_ros_shim might make more sense.

@esteve esteve requested review from maspe36 and jhdcs August 8, 2025 16:47
Copy link
Collaborator

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes appear fine to me, and it doesn't seem to bother CI at all. This should be good to merge.

@esteve
Copy link
Collaborator Author

esteve commented Aug 8, 2025

@jhdcs thanks for the prompt review

@esteve esteve merged commit cf64a41 into ros2-rust:main Aug 8, 2025
9 checks passed
@esteve esteve deleted the rename-cargo-feature branch August 8, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants