fix: added generated bindings for ROS Humble, Jazzy, Kilted and Rolling #512
+29,571
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteve Fernandez <[email protected]>
…ings in build.rs. Added GitHub workflow to update the generated bindings every night Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
esteve
changed the title
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
maspe36
reviewed
Aug 17, 2025
Signed-off-by: Esteve Fernandez <[email protected]>
jhdcs
reviewed
Aug 18, 2025
There was a problem hiding this comment.
There seems to be a fair amount being removed from the build script. Is this functionality no longer needed?
There was a problem hiding this comment.
I've removed the code that generates the bindings from the build.rs script and moved it to the CI, that way there's only one source of truth for the bindings and they'll be the same for everyone who uses rclrs. If anyone wants to generate the bindings locally, they can use the generate_bindings.py script.
nwn
reviewed
Aug 18, 2025
Comment on lines
+5
to
+8
| # Run the CI at 02:22 UTC every Tuesday | ||
| # We pick an arbitrary time outside of most of the world's work hours | ||
| # to minimize the likelihood of running alongside a heavy workload. | ||
| - cron: '22 2 * * 2' |
There was a problem hiding this comment.
The PR description says this will run daily, but this looks like it's actually weekly. Is that intentional?
There was a problem hiding this comment.
Good catch, I've submitted #515 to fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generated bindings for Humble, Jazzy, Kilted and Rolling to the source tree.
It also adds a workflow job that generates the bindings on demand and daily, and opens a PR with the changes.