Fix executor timeout #519
Merged
Fix executor timeout #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
esteve
approved these changes
Aug 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by #518 the current main branch experiences a segfault when the user specifies a timeout.
The timeout was caused by a subtle bug where we were exiting from
WaitSet::waitearly when an error code gets returned fromrcl_wait. The original rationale was that if an error happens then it is not valid to continue processing the wait set, and the user will not want to keep spinning it. However, that overlooked two things:rcl_waitwhich get skipped if we exitWaitSet::waitearlyThis PR tweaks the ordering so that we always do the appropriate cleanup each time
WaitSet::waitis called, even if an error is encountered. This also adds a test which currently experiences a segmentation fault on main.