Skip to content

Conversation

maspe36
Copy link
Collaborator

@maspe36 maspe36 commented Sep 1, 2025

Noticed two issues in our Generate bindings action.

  1. We are trying to run git diff in rclrs/src (which is failing)
warning: Not a git repository. Use --no-index to compare two paths outside a working tree
  1. The repo needs to be marked as a safe directory
fatal: detected dubious ownership in repository at '/__w/ros2_rust/ros2_rust'

Not quite sure how to test this since the generate bindings action is on a timer 🤔

@maspe36 maspe36 requested review from esteve and jhdcs September 1, 2025 19:02
@esteve
Copy link
Collaborator

esteve commented Sep 1, 2025

@maspe36 thanks! We can trigger a run after merging, no need to wait until the timer runs it.

@esteve esteve merged commit a3ce69b into ros2-rust:main Sep 1, 2025
9 checks passed
@maspe36 maspe36 deleted the chore/fix-ci branch September 1, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants