Skip to content

Conversation

@knmcguire
Copy link
Contributor

@knmcguire knmcguire commented Nov 3, 2025

Try out number 3 to fix the bindings CI once and for all!

I've added:

  • A branch name variable
  • A better PR check
  • Removed the rebase and do a force push this time
  • A whole bunch of echos to keep the debug a bit more readable...

@esteve perhaps you can first try this out by going to the action, and press run_workflow on this branch. If that works on remote branches though...

@esteve
Copy link
Collaborator

esteve commented Nov 3, 2025

@knmcguire thanks! It doesn't look like I can trigger an action from a remote repo. Is this PR ready for review?

@esteve esteve self-requested a review November 3, 2025 16:53
@knmcguire knmcguire marked this pull request as ready for review November 3, 2025 18:05
@knmcguire
Copy link
Contributor Author

Go for it! 🤠

Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve merged commit 0654994 into ros2-rust:main Nov 3, 2025
9 checks passed
@knmcguire knmcguire deleted the fix-binding-ci-2 branch November 4, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants