Skip to content

Conversation

@bresilla
Copy link

@bresilla bresilla commented Jan 24, 2026

What

  • Re-export rcl_bindings (pub mod rcl_bindings) to enable low-level extensions.
  • Add first-class serialized messaging types:
    • SerializedMessage
    • SerializedSubscription
    • SerializedPublisher
  • Add Node::create_serialized_subscription(...) and Node::create_serialized_publisher(...).

Why

Enables native tools (e.g. rosbag MCAP record/play) to work with raw serialized CDR bytes without needing generated Rust message crates.

Notes

  • Uses existing dynamic message typesupport resolution (DynamicMessageMetadata) so it works for any installed message type.
  • Does not change existing typed or dynamic pub/sub behavior.

Copilot AI review requested due to automatic review settings January 24, 2026 22:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-exports the generated low-level rcl_bindings module from rclrs so downstream crates can use raw rcl/rmw APIs without duplicating bindings.

Changes:

  • Makes the internal rcl_bindings module public (pub mod rcl_bindings;).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


#[cfg(test)]
mod test_helpers;

Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib.rs has #![warn(missing_docs)], and CI runs cargo rustdoc -- -D warnings / cargo clippy ... -D warnings. Making rcl_bindings public without a doc comment will emit a missing_docs warning for this module item and fail CI. Add a /// doc comment for pub mod rcl_bindings; (or annotate this item with #[allow(missing_docs)] / #[doc(hidden)] if you don't want it documented).

Suggested change
/// Low-level bindings to the underlying ROS 2 `rcl` C API.

Copilot uses AI. Check for mistakes.
@bresilla bresilla changed the title feat: re-export rcl bindings feat: add serialized pub/sub APIs Jan 25, 2026
@mxgrey
Copy link
Collaborator

mxgrey commented Jan 25, 2026

Is this possibly a duplicate of the feature introduced by #492 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants