Skip to content

Fix duplicate symbol error for collect_metrics flag in offline_node (Issue #80) #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
discodyer wants to merge 1 commit into
base: ros2
Choose a base branch
from
+9 −2
Open

Fix duplicate symbol error for collect_metrics flag in offline_node (Issue #80) #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cartographer_ros/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ add_library(${PROJECT_NAME} SHARED
src/node_constants.cpp
src/node.cpp
src/node_options.cpp
src/offline_node.cpp
src/playable_bag.cpp
src/ros_log_sink.cpp
src/ros_map.cpp
Expand Down Expand Up @@ -164,17 +163,24 @@ target_link_libraries(cartographer_occupancy_grid_node PRIVATE
rclcpp::rclcpp
)

add_executable(cartographer_offline_node src/offline_node_main.cpp)
add_executable(cartographer_offline_node
src/offline_node_main.cpp
src/offline_node.cpp
)
target_include_directories(cartographer_offline_node PRIVATE
"$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
"$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>"
"$<INSTALL_INTERFACE:include/${PROJECT_NAME}>"
)
if ("$ENV{ROS_DISTRO}" STRLESS "kilted")
target_compile_definitions(cartographer_offline_node PRIVATE "-DUSE_URDF_H_FILES")
endif()
target_link_libraries(cartographer_offline_node PRIVATE
${PROJECT_NAME}
cartographer
gflags
rclcpp::rclcpp
urdf::urdf
)

add_executable(cartographer_assets_writer src/assets_writer_main.cpp)
Expand Down Expand Up @@ -247,6 +253,7 @@ target_link_libraries(cartographer_rosbag_validate

if($ENV{ROS_DISTRO} MATCHES "humble" OR $ENV{ROS_DISTRO} MATCHES "iron")
target_compile_definitions(${PROJECT_NAME} PRIVATE PRE_JAZZY_SERIALIZED_BAG_MSG_FIELD_NAME)
target_compile_definitions(cartographer_offline_node PRIVATE PRE_JAZZY_SERIALIZED_BAG_MSG_FIELD_NAME)
target_compile_definitions(cartographer_rosbag_validate PRIVATE PRE_JAZZY_SERIALIZED_BAG_MSG_FIELD_NAME)
endif()

Expand Down