Skip to content

Update for supporting multiple logging level settings #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 6, 2020
Merged

Update for supporting multiple logging level settings #290

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25927ea
Update for supporting multiple logging level settings
Jun 28, 2020
35231ad
Update articles/150_ros_command_line_arguments.md
Jun 29, 2020
982fb1a
Apply suggestions from code review
Jun 30, 2020
9a4ec40
Update section name
Jun 30, 2020
8e4d9f0
Update articles/150_ros_command_line_arguments.md
Jul 1, 2020
8f98b53
Update for nitpick
Jul 2, 2020
dd04e94
Update articles/150_ros_command_line_arguments.md
Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions articles/150_ros_command_line_arguments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,24 @@ another_node:
string_param: bar
```

#### Logging level
#### Logging level assignments

Minimum logging level can be externally set using the `--log-level` option.
Minimum logging level can be externally set either globally or per logger using the `--log-level` option.

As an example, to set logging level to `DEBUG` for `some_ros_executable`, one may execute:
As an example, to set a global logging level to `DEBUG` for `some_ros_executable`, one may execute:

```sh
ros2 run some_package some_ros_executable --ros-args --log-level DEBUG
```

Some specific loggers can be set using the `--log-level` option as well:
Copy link
Member

@wjwwood wjwwood Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does Some here mean there are loggers you cannot set this way? If not, I'd drop it. If so, then I think we need some clarification on that.


```sh
ros2 run some_package some_ros_executable --ros-args --log-level talker1:=DEBUG --log-level talker2:=WARN
Copy link
Member

@wjwwood wjwwood Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to have an example that's not just a node, like maybe rclcpp or talker1.rclcpp or something more interesting like that.

```

The minimum logging level of a specific logger will override the globally specified minimum logger level.

See `rcutils` and `rcl` logging documentation for reference on existing logging levels.

#### External logging configuration
Expand Down