Replace deprecated spin_until_future_complete #339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Due to change in RCLCPP - ros2/rclcpp#1874 Pull request |
fujitatomoya
requested changes
Apr 1, 2022
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
we should avoid unnecessary changes which are irrelevant to this PR.
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
573209c to
b68b4e1
Compare
Author
|
ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together. |
fujitatomoya
approved these changes
Apr 11, 2022
Signed-off-by: Hubert Liberacki <[email protected]>
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
32e42dc to
cdf96c7
Compare
SteveMacenski
approved these changes
Jun 24, 2022
Member
|
I've opened #376 to replace this PR. |
Member
|
This can be closed, see #376 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated spin_until_future_complete with spin_until_complete
Signed-off-by: Hubert Liberacki [email protected]