fix: Fixed compilation after API change of TimerBase::execute #375
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI:
|
fujitatomoya
requested changes
Mar 29, 2024
rclcpp/topics/minimal_subscriber/time_triggered_wait_set_subscriber.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Janosch Machowinski <[email protected]>
jmachowinski
force-pushed
the
timer_compile_fix
branch
from
a88add6 to
375e0e2
Compare
fujitatomoya
approved these changes
Mar 29, 2024
Collaborator
|
@jmachowinski i will wait for ros2/rcl#1142. and then, i will start the CI with ros2/rclcpp#2343 |
mjcarroll
approved these changes
Apr 12, 2024
apojomovsky
pushed a commit
to apojomovsky/examples
that referenced
this pull request
May 16, 2024
Signed-off-by: Janosch Machowinski <[email protected]> Co-authored-by: Janosch Machowinski <[email protected]>
apojomovsky
pushed a commit
to apojomovsky/examples
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Janosch Machowinski <[email protected]> Co-authored-by: Janosch Machowinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of ros2/rclcpp#2343