Add pluginlib tutorial code #430
Open
+337
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mini-1235 <[email protected]>
ahcorde
requested changes
Nov 6, 2025
Comment on lines
38
to
44
| # the following line skips the linter which checks for copyrights | ||
| # comment the line when a copyright and license is added to all source files | ||
| set(ament_cmake_copyright_FOUND TRUE) | ||
| # the following line skips cpplint (only works in a git repo) | ||
| # comment the line when this package is in a git repo and when | ||
| # a copyright and license is added to all source files | ||
| set(ament_cmake_cpplint_FOUND TRUE) |
There was a problem hiding this comment.
Remove, these linters should work
| <package format="2"> | ||
| <name>polygon_base</name> | ||
| <version>0.21.3</version> | ||
| <description>Examples of polygon base</description> |
|
|
||
| <license>Apache License 2.0</license> | ||
|
|
||
| <author email="[email protected]">Jacob Perron</author> |
| <package format="2"> | ||
| <name>polygon_plugins</name> | ||
| <version>0.21.3</version> | ||
| <description>Example of polygon plugins</description> |
|
|
||
| <license>Apache License 2.0</license> | ||
|
|
||
| <author email="[email protected]">Jacob Perron</author> |
| <class type="polygon_plugins::Triangle" base_class_type="polygon_base::RegularPolygon" name="awesome_triangle"> | ||
| <description>This is a triangle plugin.</description> | ||
| </class> | ||
| </library> No newline at end of file |
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
mini-1235
commented
Nov 6, 2025
| <?xml version="1.0"?> | ||
| <?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?> | ||
| <package format="2"> | ||
| <name>polygon_base</name> |
There was a problem hiding this comment.
Why do you want to do that? and into what name?
and if we do that, probably the tutorial in the documentation should be changed accordingly to keep the consistency?
fujitatomoya
requested changes
Nov 7, 2025
There was a problem hiding this comment.
IMO, this example should not stay in this repository.
- this examples repository provides the examples how to use APIs and interfaces provided by rclcpp, such as endpoints, nodes, waitsets and so on.
- plugin is NOT provided by rclcpp, and rclcpp feature neither. if we take this, everything cpp can be example in this repository.
- i highly suggest this example should be maintained in https://github.com/ros/pluginlib, because that is the library provides the APIs and interfaces. (and probably go through the release process as well to release the package for the distribution)
| @@ -0,0 +1,3 @@ | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
There was a problem hiding this comment.
Is this supposed to be during release process? we are planning to release this package, correct?
| <?xml version="1.0"?> | ||
| <?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?> | ||
| <package format="2"> | ||
| <name>polygon_base</name> |
There was a problem hiding this comment.
Why do you want to do that? and into what name?
and if we do that, probably the tutorial in the documentation should be changed accordingly to keep the consistency?
| @@ -0,0 +1,3 @@ | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
There was a problem hiding this comment.
same here. i think this should be generated by release tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the code from https://docs.ros.org/en/rolling/Tutorials/Beginner-Client-Libraries/Pluginlib.html.
Note that this PR moves the
area_nodeexecutable frompolygon_basetopolygon_plugins, if the maintainers approve, I can also open a PR to update the documentationFixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information