Skip to content

Commit e04bc74

Browse files
committed
Re-enable unstamped eigen tests
they were disabled because of MSVC and ADL (MSVC couldn't choose between tf2::toMsg and Eigen::toMsg)
1 parent 4c0d0b6 commit e04bc74

File tree

1 file changed

+21
-22
lines changed

1 file changed

+21
-22
lines changed

tf2_eigen/test/tf2_eigen-test.cpp

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,17 @@ TEST(TfEigen, ConvertVector3dStamped)
7979
EXPECT_EQ(v, v1);
8080
}
8181

82-
// TODO(clalancette) Re-enable these tests once we have tf2/convert.h:convert(A, B) implemented
83-
// TEST(TfEigen, ConvertVector3d)
84-
// {
85-
// const Eigen::Vector3d v(1,2,3);
82+
TEST(TfEigen, ConvertVector3d)
83+
{
84+
const Eigen::Vector3d v(1, 2, 3);
8685

87-
// Eigen::Vector3d v1;
88-
// geometry_msgs::msg::Point p1;
89-
// tf2::convert(v, p1);
90-
// tf2::convert(p1, v1);
86+
Eigen::Vector3d v1;
87+
geometry_msgs::msg::Point p1;
88+
tf2::convert(v, p1);
89+
tf2::convert(p1, v1);
9190

92-
// EXPECT_EQ(v, v1);
93-
// }
91+
EXPECT_EQ(v, v1);
92+
}
9493

9594
TEST(TfEigen, ConvertAffine3dStamped)
9695
{
@@ -110,20 +109,20 @@ TEST(TfEigen, ConvertAffine3dStamped)
110109
EXPECT_EQ(v.stamp_, v1.stamp_);
111110
}
112111

113-
// TODO(clalancette) Re-enable these tests once we have tf2/convert.h:convert(A, B) implemented
114-
// TEST(TfEigen, ConvertAffine3d)
115-
// {
116-
// const Eigen::Affine3d v(
117-
// Eigen::Translation3d(1,2,3) * Eigen::AngleAxis<double>(1, Eigen::Vector3d::UnitX()));
112+
TEST(TfEigen, ConvertAffine3d)
113+
{
114+
const Eigen::Affine3d v(Eigen::Translation3d(1, 2, 3) * Eigen::AngleAxis<double>(
115+
1,
116+
Eigen::Vector3d::UnitX()));
118117

119-
// Eigen::Affine3d v1;
120-
// geometry_msgs::msg::Pose p1;
121-
// tf2::convert(v, p1);
122-
// tf2::convert(p1, v1);
118+
Eigen::Affine3d v1;
119+
geometry_msgs::msg::Pose p1;
120+
tf2::convert(v, p1);
121+
tf2::convert(p1, v1);
123122

124-
// EXPECT_EQ(v.translation(), v1.translation());
125-
// EXPECT_EQ(v.rotation(), v1.rotation());
126-
// }
123+
EXPECT_EQ(v.translation(), v1.translation());
124+
EXPECT_EQ(v.rotation(), v1.rotation());
125+
}
127126

128127
TEST(TfEigen, ConvertTransform)
129128
{

0 commit comments

Comments
 (0)