Skip to content

Warning Message Intervals for canTransform #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Warning Message Intervals for canTransform #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62085be
canTransform warning intervals
CursedRock17 Mar 17, 2024
2417a39
Rounding out all of the buffer classes
CursedRock17 Mar 17, 2024
02003cb
Adding local variable for throttle value
CursedRock17 Mar 25, 2024
9bcf0e6
Fixing Windows Issue
CursedRock17 Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tf2/include/tf2/buffer_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@

#include "LinearMath/Transform.h"
#include "geometry_msgs/msg/transform_stamped.hpp"
#include "rcutils/logging_macros.h"
#include "tf2/buffer_core_interface.h"
#include "tf2/exceptions.h"
#include "tf2/transform_storage.h"
#include "tf2/visibility_control.h"
#include "rcutils/logging_macros.h"

namespace tf2
{
Expand Down
5 changes: 4 additions & 1 deletion tf2/src/buffer_core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ void fillOrWarnMessageForInvalidFrame(
if (error_msg != nullptr) {
*error_msg = s;
} else {
RCUTILS_LOG_WARN("%s", s.c_str());
static constexpr std::chrono::milliseconds warning_interval =
std::chrono::milliseconds(2500);

RCUTILS_LOG_WARN_THROTTLE(RCUTILS_STEADY_TIME, warning_interval.count(), "%s", s.c_str());
}
}

Expand Down