Skip to content

Deprecate C Headers #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahcorde merged 10 commits into from
Dec 18, 2024
Merged

Deprecate C Headers #720

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5fa084c
Deprecating C Headers
CursedRock17 Oct 26, 2024
43857b1
Tunning header guards
CursedRock17 Oct 26, 2024
4d67a64
Fixing header order
CursedRock17 Oct 27, 2024
6288ba5
Fixing Copyrighting
CursedRock17 Oct 28, 2024
62879df
Removing LinearMath C++ Header
CursedRock17 Nov 5, 2024
177de4d
Revert "Removing LinearMath C++ Header"
CursedRock17 Nov 5, 2024
3a21ba2
Linter Matrix3x3.h
CursedRock17 Nov 6, 2024
f390cce
Reverting visibility_control changes
CursedRock17 Nov 6, 2024
8a0c770
Fixing
CursedRock17 Nov 7, 2024
d63c6a1
Whitespacing Issues
CursedRock17 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test_tf2/test/buffer_core_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@
#include <geometry_msgs/msg/transform.hpp>
#include <geometry_msgs/msg/transform_stamped.hpp>
#include <rclcpp/rclcpp.hpp>
#include <tf2/buffer_core.h>
#include <tf2/exceptions.h>
#include <tf2/LinearMath/Quaternion.h>
#include <tf2/time.h>
#include <tf2/buffer_core.hpp>
#include <tf2/exceptions.hpp>
#include <tf2/LinearMath/Quaternion.hpp>
#include <tf2/time.hpp>
#include <tf2_geometry_msgs/tf2_geometry_msgs.hpp>
#include <tf2_ros/buffer_interface.h>

Expand Down
4 changes: 2 additions & 2 deletions test_tf2/test/test_convert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
#include <geometry_msgs/msg/point_stamped.hpp>
#include <geometry_msgs/msg/point.hpp>
#include <geometry_msgs/msg/vector3.hpp>
#include <tf2/convert.h>
#include <tf2/LinearMath/Quaternion.h>
#include <tf2/convert.hpp>
#include <tf2/LinearMath/Quaternion.hpp>
#include <tf2_kdl/tf2_kdl.hpp>
#include <tf2_bullet/tf2_bullet.hpp>
#include <tf2_eigen/tf2_eigen.hpp>
Expand Down
8 changes: 4 additions & 4 deletions test_tf2/test/test_message_filter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
#include <geometry_msgs/msg/point_stamped.hpp>
#include <geometry_msgs/msg/transform_stamped.hpp>
#include <rclcpp/rclcpp.hpp>
#include <tf2/buffer_core.h>
#include <tf2/LinearMath/Quaternion.h>
#include <tf2/LinearMath/Vector3.h>
#include <tf2/time.h>
#include <tf2/buffer_core.hpp>
#include <tf2/LinearMath/Quaternion.hpp>
#include <tf2/LinearMath/Vector3.hpp>
#include <tf2/time.hpp>
#include <tf2_ros/buffer_interface.h>
#include <tf2_ros/create_timer_ros.h>
#include <tf2_ros/message_filter.h>
Expand Down
6 changes: 3 additions & 3 deletions test_tf2/test/test_static_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@

#include <geometry_msgs/msg/transform_stamped.hpp>
#include <rclcpp/rclcpp.hpp>
#include <tf2/buffer_core.h>
#include <tf2/exceptions.h>
#include <tf2/time.h>
#include <tf2/buffer_core.hpp>
#include <tf2/exceptions.hpp>
#include <tf2/time.hpp>
#include <tf2_ros/buffer.h>
#include <tf2_ros/buffer_interface.h>
#include <tf2_ros/static_transform_broadcaster.h>
Expand Down
2 changes: 1 addition & 1 deletion test_tf2/test/test_tf2_bullet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include <tf2_ros/buffer.h>
#include <rclcpp/rclcpp.hpp>
#include <gtest/gtest.h>
#include <tf2/convert.h>
#include <tf2/convert.hpp>

std::unique_ptr<tf2_ros::Buffer> tf_buffer = nullptr;
static const double EPS = 1e-3;
Expand Down
4 changes: 2 additions & 2 deletions test_tf2/test/test_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
#include <geometry_msgs/msg/quaternion_stamped.hpp>
#include <geometry_msgs/msg/transform.hpp>
#include <tf2_geometry_msgs/tf2_geometry_msgs.hpp>
#include <tf2/LinearMath/Quaternion.h>
#include <tf2/utils.h>
#include <tf2/LinearMath/Quaternion.hpp>
#include <tf2/utils.hpp>
#include <tf2_kdl/tf2_kdl.hpp>

double epsilon = 1e-9;
Expand Down
14 changes: 7 additions & 7 deletions tf2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ if(BUILD_TESTING)
# Should not lint external code
set(
_linter_excludes
include/tf2/LinearMath/Matrix3x3.h
include/tf2/LinearMath/MinMax.h
include/tf2/LinearMath/QuadWord.h
include/tf2/LinearMath/Quaternion.h
include/tf2/LinearMath/Scalar.h
include/tf2/LinearMath/Transform.h
include/tf2/LinearMath/Vector3.h
include/tf2/LinearMath/Matrix3x3.hpp
Copy link
Contributor

@ahcorde ahcorde Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should keep here both the h and the hpp

Copy link
Contributor

@clalancette clalancette Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should keep here both the h and the hpp

Agreed.

include/tf2/LinearMath/MinMax.hpp
include/tf2/LinearMath/QuadWord.hpp
include/tf2/LinearMath/Quaternion.hpp
include/tf2/LinearMath/Scalar.hpp
include/tf2/LinearMath/Transform.hpp
include/tf2/LinearMath/Vector3.hpp
)

ament_copyright(EXCLUDE ${_linter_excludes})
Expand Down
Loading