Skip to content

Jazzy "Backport" of #720 #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahcorde merged 3 commits into from
Dec 19, 2024
Merged

Jazzy "Backport" of #720 #723

ahcorde merged 3 commits into from
Dec 19, 2024

Conversation

@CursedRock17
Copy link
Contributor

@CursedRock17 CursedRock17 commented Oct 30, 2024

Jazzy "Backport" of #720 in which we added .hpp versions of the .h files in tf2, but without the warning message to get backwards compatibility and prevent weird syntax like this:

#if __has_include(<cv_bridge/cv_bridge.hpp>)
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
#else
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
#endif

@CursedRock17
Removing C Headers tf2 Jazzy Backport
0bcf12e 
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@CursedRock17 CursedRock17 mentioned this pull request Oct 30, 2024
Merged
@CursedRock17
Fixing Header Order
24111a7 
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>

Update Matrix3x3.h

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Matrix3x3.hpp

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update MinMax.h

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update MinMax.hpp

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update QuadWord.h

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update QuadWord.hpp

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Quaternion.h

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Quaternion.hpp

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Scalar.h

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Scalar.hpp

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Transform.h

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Transform.hpp

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Vector3.h

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>

Update Vector3.hpp

Signed-off-by: Lucas Wendland <82680922+CursedRock17@users.noreply.github.com>
@CursedRock17 CursedRock17 force-pushed the deprecate_tf2_headers_jazzy branch from 74a08f2 to 24111a7 Compare November 8, 2024 06:33
@CursedRock17
Fixing Visibility Controls
d135e27 
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 18, 2024 •
edited
Loading

Pulls: #723
Gist: https://gist.githubusercontent.com/ahcorde/873f442f5f28016107cb5bdeac1dc764/raw/d7367e5724d8c0a5ea10f0784bfbca96fb4a9e7e/ros2.repos
BUILD args: --packages-above-and-dependencies test_tf2 tf2 tf2_bullet tf2_eigen tf2_eigen_kdl tf2_geometry_msgs tf2_kdl tf2_py tf2_ros tf2_sensor_msgs --packages-above-and-dependencies test_tf2 tf2 tf2_bullet tf2_eigen tf2_eigen_kdl tf2_geometry_msgs tf2_kdl tf2_py tf2_ros tf2_sensor_msgs
TEST args: --packages-above test_tf2 tf2 tf2_bullet tf2_eigen tf2_eigen_kdl tf2_geometry_msgs tf2_kdl tf2_py tf2_ros tf2_sensor_msgs --packages-above test_tf2 tf2 tf2_bullet tf2_eigen tf2_eigen_kdl tf2_geometry_msgs tf2_kdl tf2_py tf2_ros tf2_sensor_msgs
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14978

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit ccacda4 into ros2:jazzy Dec 19, 2024
@CursedRock17 CursedRock17 deleted the deprecate_tf2_headers_jazzy branch January 17, 2025 03:48
@sloretz sloretz mentioned this pull request Jul 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@clalancette clalancette

Labels

backlog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CursedRock17 @ahcorde @clalancette @mjcarroll